Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links with kubeflow/examples as base #1003

Conversation

kimwnasptd
Copy link
Member

@jimmyguerrero noticed that some links are not working as expected. cc @josepholaide

A lot of links were using the repo https://github.com/josepholaide/examples as hardcoded.

This PR updates all links to either

  1. Use a relative URL, so that files from this repo are used
  2. Use the kubeflow/examples repo (master) explicitly, in case of download links

Signed-off-by: Kimonas Sotirchos kimwnasptd@arrikto.com

Previously a lot of links were using the repo
https://github.com/josepholaide/examples as hardcoded.

This PR updates all links to either
1. Use a relative URL, so that files from this repo are used
2. Use the kubeflow/examples repo (master) explicitly, in case of
   download links

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@akgraner
Copy link

akgraner commented Nov 1, 2022

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akgraner, kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 4da3cd5 into kubeflow:master Nov 1, 2022
@kimwnasptd kimwnasptd deleted the feature-kimwnasptd-american-express-kaggle-images branch November 1, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants