Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write xgboost_synthetic test output to html #735

Merged
merged 20 commits into from
Feb 15, 2020

Conversation

gabrielwen
Copy link
Contributor

@gabrielwen gabrielwen commented Feb 13, 2020

@gabrielwen gabrielwen changed the title [WIP] Write xgboost_synthetic test output to html Write xgboost_synthetic test output to html Feb 14, 2020
@jlewi
Copy link
Contributor

jlewi commented Feb 14, 2020

@gabrielwen this is great. Instead of writing it to a bucket in kubeflow-ci-deployment; could we write it to the GCS location used by prow for results so that it shows up in spyglass?

  1. Here's the spyglass results for the most recent presubmit run
  2. I'd like to click on artifacts and see the HTML file there.

You can use this function to get the gcs_dir for the results based on the environment variables that prow sets.
https://github.com/kubeflow/testing/blob/43b78260019e15be19a29800a88fa63a6e132bae/py/kubeflow/testing/prow_artifacts.py#L110

@gabrielwen
Copy link
Contributor Author

@gabrielwen this is great. Instead of writing it to a bucket in kubeflow-ci-deployment; could we write it to the GCS location used by prow for results so that it shows up in spyglass?

  1. Here's the spyglass results for the most recent presubmit run
  2. I'd like to click on artifacts and see the HTML file there.

You can use this function to get the gcs_dir for the results based on the environment variables that prow sets.
https://github.com/kubeflow/testing/blob/43b78260019e15be19a29800a88fa63a6e132bae/py/kubeflow/testing/prow_artifacts.py#L110

seems like the pod running execute_notebook doesn't have permission to write to that GCS bucket. let me see how to make this work.

@jlewi
Copy link
Contributor

jlewi commented Feb 14, 2020

@gabrielwen the pod that's running the pytest (i.e. that launches the K8s job) should have permission to write to kubernetes-jenkins. So that pod could copy it from the GCS location that execute_notebook writes to.

@gabrielwen
Copy link
Contributor Author

@gabrielwen the pod that's running the pytest (i.e. that launches the K8s job) should have permission to write to kubernetes-jenkins. So that pod could copy it from the GCS location that execute_notebook writes to.

right, that's exactly I'm trying to do.

@jlewi
Copy link
Contributor

jlewi commented Feb 15, 2020

@gabrielwen let me know when this is ready for another review?

@jlewi
Copy link
Contributor

jlewi commented Feb 15, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants