-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write xgboost_synthetic test output to html #735
Conversation
10b98d3
to
abc339f
Compare
987c84e
to
d1b4df6
Compare
@gabrielwen this is great. Instead of writing it to a bucket in kubeflow-ci-deployment; could we write it to the GCS location used by prow for results so that it shows up in spyglass?
You can use this function to get the gcs_dir for the results based on the environment variables that prow sets. |
seems like the pod running |
8b7ee00
to
f6b6893
Compare
2a4be27
to
457e610
Compare
eab2876
to
175e0e8
Compare
@gabrielwen the pod that's running the pytest (i.e. that launches the K8s job) should have permission to write to kubernetes-jenkins. So that pod could copy it from the GCS location that execute_notebook writes to. |
right, that's exactly I'm trying to do. |
57efcb2
to
cf23322
Compare
2def8c1
to
09045fb
Compare
@gabrielwen let me know when this is ready for another review? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Write testing notebook to GCS:
https://pantheon.corp.google.com/storage/browser/kubeflow-ci-deployment/xgboost_synthetic_testing?project=kubeflow-ci-deployment
Related: kubeflow/manifests#757
This change is