-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fairing in mnist to 1.0.1 #807
Conversation
/assign @iancoffey Related to GoogleCloudPlatform/kubeflow-distribution#65 |
Tests are broken for unrelated reasons.
|
#808 disables the flaky tests until they can be fixed |
/lgtm |
@jlewi Personally I suggest to fix the problem in the Fairing, better than work around here :-) I will fix this in Fairing and release new one (maybe v1.0.1) with high priority. Thanks. /hold |
|
Thanks @jinchihe will try that. |
This addresses kserve/kserve#806. Fairing 1.0.0 isn't compatible with kfserving 0.3.2
@jinchihe Fixed could you please LGTM? I updated to 1.0.1 and that seems to fix the problem and it is working correctly. |
/lgtm Thanks @jlewi |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jinchihe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
This is a fix for kserve/kserve#806. The existing version of
fairing isn't compatible with the 0.3 version of the KFServing SDK.