Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fairing in mnist to 1.0.1 #807

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Jul 6, 2020

This is a fix for kserve/kserve#806. The existing version of
fairing isn't compatible with the 0.3 version of the KFServing SDK.

@kubeflow-bot
Copy link

This change is Reviewable

@jlewi
Copy link
Contributor Author

jlewi commented Jul 6, 2020

/assign @iancoffey
/assign @Bobgy
/assign @jinchihe

Related to GoogleCloudPlatform/kubeflow-distribution#65

@jlewi
Copy link
Contributor Author

jlewi commented Jul 6, 2020

Tests are broken for unrelated reasons.

W
Traceback (most recent call last):
 File "/usr/lib/python3.5/runpy.py", line 174, in _run_module_as_main
   mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
 File "/usr/lib/python3.5/runpy.py", line 144, in _get_module_details
   code = loader.get_code(mod_name)
 File "<frozen importlib._bootstrap_external>", line 767, in get_code
 File "<frozen importlib._bootstrap_external>", line 727, in source_to_code
 File "<frozen importlib._bootstrap>", line 222, in _call_with_frames_removed
 File "/mnt/test-data-volume/kubeflow-examples-presubmit-notebooks-v1-807-d67e7fa-3344-b6fe/src/kubeflow/testing/py/kubeflow/testing/get_kf_testing_cluster.py", line 404
   logging.info(f"Writing cluster information to {output}")
                                                         ^
SyntaxError: invalid syntax

@jlewi
Copy link
Contributor Author

jlewi commented Jul 6, 2020

#808 disables the flaky tests until they can be fixed

@Bobgy
Copy link

Bobgy commented Jul 7, 2020

/lgtm

@jinchihe
Copy link
Member

jinchihe commented Jul 7, 2020

@jlewi Personally I suggest to fix the problem in the Fairing, better than work around here :-) I will fix this in Fairing and release new one (maybe v1.0.1) with high priority. Thanks.

/hold

@jinchihe
Copy link
Member

jinchihe commented Jul 7, 2020

kubeflow-fairing v1.0.1 has been released, now we can try the case with new SDK. Thanks.
https://pypi.org/project/kubeflow-fairing/1.0.1/

@jlewi
Copy link
Contributor Author

jlewi commented Jul 7, 2020

Thanks @jinchihe will try that.

This addresses kserve/kserve#806. Fairing 1.0.0 isn't compatible with kfserving 0.3.2
@k8s-ci-robot k8s-ci-robot removed the lgtm label Jul 7, 2020
@jlewi jlewi changed the title Pin KFServing to 0.2 release in the mnist example. Update fairing in mnist to 1.0.1 Jul 7, 2020
@jlewi
Copy link
Contributor Author

jlewi commented Jul 7, 2020

@jinchihe Fixed could you please LGTM? I updated to 1.0.1 and that seems to fix the problem and it is working correctly.

@jinchihe
Copy link
Member

jinchihe commented Jul 8, 2020

/lgtm
/approve

Thanks @jlewi

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jinchihe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jinchihe
Copy link
Member

jinchihe commented Jul 8, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 7bde5b4 into kubeflow:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants