Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add droctothorpe as member #657

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

droctothorpe
Copy link
Contributor

Closed this issue in favor of this PR. There are some conflicting instructions on the website vs the readme here / community repo.

Please provide links to PRs or other contributions (2-3):

** Please list 2 existing members who are sponsoring your membership:**
@connor-mccarthy
@andreyvelich

** Please test your PR **

Run

cd github_orgs
pytest test_org_yaml.py

Include the output in the PR

===================================================================================== test session starts =====================================================================================
platform darwin -- Python 3.11.4, pytest-7.4.3, pluggy-1.0.0
rootdir: /Users/inn487/code/kubeflow/internal-acls/github-orgs
plugins: anyio-4.0.0, cov-4.1.0
collected 1 item

test_org_yaml.py .                                                                                                                                                                      [100%]

====================================================================================== 1 passed in 0.11s ======================================================================================

Copy link

Hi @droctothorpe. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks again for all of your great contributions @droctothorpe 🎉
/assign @james-jwu @zijianjoy

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@james-jwu
Copy link
Contributor

/lgtm
/approve

@andreyvelich
Copy link
Member

@droctothorpe Please sign your commit for DCO.

Signed-off-by: droctothorpe <mythicalsunlight@gmail.com>
@droctothorpe
Copy link
Contributor Author

@droctothorpe Please sign your commit for DCO.

Thanks, @andreyvelich. Fixed! 👍

@andreyvelich
Copy link
Member

Great, thanks @droctothorpe!
/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Feb 28, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, droctothorpe, james-jwu, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andreyvelich,james-jwu,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit ce5d212 into kubeflow:master Feb 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REQUEST: New membership for droctothorpe
5 participants