Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Electronic-Waste as member. #669

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

Electronic-Waste
Copy link
Member

@Electronic-Waste Electronic-Waste commented Apr 8, 2024

Links to PRs:

Pytest output:

======================================================= test session starts ========================================================
platform linux -- Python 3.8.10, pytest-8.1.1, pluggy-1.4.0
rootdir: /home/wangshao/internal-acls/github-orgs
collected 1 item                                                                                                                   

test_org_yaml.py .                                                                                                           [100%]

======================================================== 1 passed in 0.24s =========================================================

PTAL👀 @andreyvelich @tenzen-y

Signed-off-by: Electronic-Waste <2690692950@qq.com>
Copy link

Hi @Electronic-Waste. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy to sponsor this request and thank you for your great contributions @Electronic-Waste 🎉

/ok-to-test
/lgtm
/assign @kubeflow/wg-training-leads

@Electronic-Waste
Copy link
Member Author

@andreyvelich Thank you for your recognition! I'll continue to contribute to Katib and other projects in Kubeflow since I really consider it a great opportunity for me to learn AI Infrastructure.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome!

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Electronic-Waste, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 4502cb3 into kubeflow:master Apr 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants