Raise an error for the step parameter

Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com>
kubeflow · Dec 17, 2022 · 09dabf7 · 09dabf7
1 parent 5e9536a
commit 09dabf7
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/pkg/suggestion/v1beta1/internal/search_space.py b/pkg/suggestion/v1beta1/internal/search_space.py
@@ -49,7 +49,7 @@ def convert_to_combinations(search_space):
                 combinations[parameter.name] = range(int(parameter.min), int(parameter.max)+1, int(parameter.step))
             elif parameter.type == DOUBLE:
                 if parameter.step == "" or parameter.step is None:
-                    return "Param {} step is nil".format(parameter.name)
+                    raise Exception("Param {} step is nil".format(parameter.name))
                 double_list = np.arange(float(parameter.min), float(parameter.max)+float(parameter.step),
                                         float(parameter.step))
                 if double_list[-1] > float(parameter.max):

diff --git a/pkg/suggestion/v1beta1/optuna/service.py b/pkg/suggestion/v1beta1/optuna/service.py
@@ -206,9 +206,6 @@ def _validate_grid_setting(cls, experiment):
 
         try:
             combinations = HyperParameterSearchSpace.convert_to_combinations(search_space)
-            if isinstance(combinations, str):
-                return False, combinations
-
             num_combinations = len(list(itertools.product(*combinations.values())))
             max_trial_count = experiment.spec.max_trial_count
             if max_trial_count > num_combinations:

diff --git a/test/unit/v1beta1/suggestion/test_optuna_service.py b/test/unit/v1beta1/suggestion/test_optuna_service.py
@@ -189,7 +189,7 @@ def test_get_suggestion(self, algorithm_name, algorithm_settings):
         ["algorithm_name", "algorithm_settings", "max_trial_count", "parameters", "result"],
         [
             # Invalid algorithm name
-            ["invalid", {}, 1, [], grpc.StatusCode.UNKNOWN],
+            ["invalid", {}, 1, [], grpc.StatusCode.INVALID_ARGUMENT],
 
             # [TPE] Valid case
             ["tpe", {"n_startup_trials": "5", "n_ei_candidates": "24", "random_state": "1"}, 100, [],