-
Notifications
You must be signed in to change notification settings - Fork 448
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
UI: Make KWA's main table responsive and add toolbar
* Add a top row toolbar with the title of the app and the button to create a new Experiment. * Replace the card with a responsive table that shows the items. The component also has a paginator. Signed-off-by: Elena Zioga <elena@arrikto.com>
- Loading branch information
Showing
4 changed files
with
31 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 17 additions & 10 deletions
27
pkg/new-ui/v1beta1/frontend/src/app/pages/experiments/experiments.component.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,18 @@ | ||
<lib-namespace-select | ||
*ngIf="(ns.dashboardConnected$ | async) === dashboardDisconnectedState" | ||
namespacesUrl="/katib/fetch_namespaces" | ||
></lib-namespace-select> | ||
<div class="lib-content-wrapper"> | ||
<lib-title-actions-toolbar title="Experiments" [buttons]="buttons" i18n-title> | ||
<lib-namespace-select | ||
*ngIf="(ns.dashboardConnected$ | async) === dashboardDisconnectedState" | ||
namespacesUrl="/katib/fetch_namespaces" | ||
></lib-namespace-select> | ||
</lib-title-actions-toolbar> | ||
|
||
<lib-resource-table | ||
[config]="config" | ||
[data]="experiments" | ||
[trackByFn]="trackByFn" | ||
(actionsEmitter)="reactToAction($event)" | ||
></lib-resource-table> | ||
<div class="page-padding lib-flex-grow lib-overflow-auto"> | ||
<lib-table | ||
[config]="config" | ||
[data]="experiments" | ||
[trackByFn]="trackByFn" | ||
(actionsEmitter)="reactToAction($event)" | ||
> | ||
</lib-table> | ||
</div> | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 2 additions & 18 deletions
20
pkg/new-ui/v1beta1/frontend/src/app/pages/experiments/experiments.module.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,12 @@ | ||
import { NgModule } from '@angular/core'; | ||
import { CommonModule } from '@angular/common'; | ||
import { MatCardModule } from '@angular/material/card'; | ||
import { | ||
NamespaceSelectModule, | ||
ResourceTableModule, | ||
ConfirmDialogModule, | ||
} from 'kubeflow'; | ||
|
||
import { KubeflowModule } from 'kubeflow'; | ||
import { ExperimentsComponent } from './experiments.component'; | ||
import { ExperimentOptimalTrialModule } from './optimal-trial/experiment-optimal-trial.module'; | ||
|
||
@NgModule({ | ||
declarations: [ExperimentsComponent], | ||
imports: [ | ||
CommonModule, | ||
NamespaceSelectModule, | ||
ResourceTableModule, | ||
|
||
ConfirmDialogModule, | ||
ExperimentOptimalTrialModule, | ||
MatCardModule, | ||
ConfirmDialogModule, | ||
MatCardModule, | ||
], | ||
imports: [CommonModule, ExperimentOptimalTrialModule, KubeflowModule], | ||
exports: [ExperimentsComponent], | ||
}) | ||
export class ExperimentsModule {} |