Add unit tests for optuna suggestion service

Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com>
kubeflow · Dec 13, 2022 · 6ba7852 · 6ba7852
1 parent 31b2d82
commit 6ba7852
Show file tree

Hide file tree

Showing 2 changed files with 135 additions and 268 deletions.
diff --git a/pkg/suggestion/v1beta1/optuna/service.py b/pkg/suggestion/v1beta1/optuna/service.py
@@ -15,7 +15,6 @@
 import threading
 import grpc
 import logging
-
 import itertools
 
 from pkg.apis.manager.v1beta1.python import api_pb2
@@ -193,11 +192,11 @@ def _validate_grid_setting(cls, experiment):
 
         for s in algorithm_settings:
             try:
-                if s.name == "seed":
+                if s.name == "random_state":
                     if not int(s.value) >= 0:
                         return False, ""
-                    else:
-                        return False, "unknown setting {} for algorithm grid".format(s.name)
+                else:
+                    return False, "unknown setting {} for algorithm grid".format(s.name)
 
             except Exception as e:
                 return False, "failed to validate {name}({value}): {exception}".format(name=s.name, value=s.value,