Skip creating trials if add count is zero (#617)

kubeflow · May 31, 2019 · 7a2ffe1 · 7a2ffe1
1 parent 1fdca87
commit 7a2ffe1
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/pkg/controller/v1alpha2/experiment/experiment_controller.go b/pkg/controller/v1alpha2/experiment/experiment_controller.go
@@ -331,13 +331,15 @@ func (r *ReconcileExperiment) ReconcileTrials(instance *experimentsv1alpha2.Expe
 			addCount = 0
 		}
 
-		//create "addCount" number of trials
-		logger.Info("CreateTrials", "addCount", addCount)
-		if err := r.createTrials(instance, addCount); err != nil {
-			logger.Error(err, "Create trials error")
-			return err
+		//skip if no trials need to be created
+		if addCount > 0 {
+			//create "addCount" number of trials
+			logger.Info("CreateTrials", "addCount", addCount)
+			if err := r.createTrials(instance, addCount); err != nil {
+				logger.Error(err, "Create trials error")
+				return err
+			}
 		}
-
 	}
 
 	return nil