feat: Use env var for namespace (#829)

Signed-off-by: Ce Gao <gaoce@caicloud.io>
kubeflow · Sep 27, 2019 · 92069c2 · 92069c2
1 parent cad5060
commit 92069c2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/manifests/v1alpha3/ui/deployment.yaml b/manifests/v1alpha3/ui/deployment.yaml
@@ -21,6 +21,11 @@ spec:
         imagePullPolicy: IfNotPresent
         command:
           - './katib-ui'
+        env:
+        - name: KATIB_CORE_NAMESPACE
+          valueFrom:
+            fieldRef:
+              fieldPath: metadata.namespace
         ports:
         - name: ui
           containerPort: 80

diff --git a/pkg/util/v1alpha3/katibclient/katib_client.go b/pkg/util/v1alpha3/katibclient/katib_client.go
@@ -17,8 +17,6 @@ package katibclient
 
 import (
 	"context"
-	"io/ioutil"
-	"strings"
 
 	apiv1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/types"
@@ -174,8 +172,7 @@ func (k *KatibClient) UpdateTrialTemplates(newTrialTemplates map[string]string,
 
 func getNamespace(namespace ...string) string {
 	if len(namespace) == 0 {
-		data, _ := ioutil.ReadFile("/var/run/secrets/kubernetes.io/serviceaccount/namespace")
-		return strings.TrimSpace(string(data))
+		return consts.DefaultKatibNamespace
 	}
 	return namespace[0]
 }