Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation] Katib webhook information #1266

Closed
andreyvelich opened this issue Jul 14, 2020 · 9 comments · Fixed by #1486
Closed

[Documentation] Katib webhook information #1266

andreyvelich opened this issue Jul 14, 2020 · 9 comments · Fixed by #1486
Labels
area/docs area/katib good first issue Good for newcomers help wanted Extra attention is needed kind/feature lifecycle/frozen priority/p0

Comments

@andreyvelich
Copy link
Member

/kind feature

We should document how admission Kubernetes webhooks is used in Katib.

Also, add information about private GKE clusters, see comment: #1258 (comment).
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/docs 0.55
area/katib 0.93

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue.
See dashboard for more details.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/front-end 0.76

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@andreyvelich
Copy link
Member Author

/good-first-issue

@k8s-ci-robot
Copy link

@andreyvelich:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 14, 2020
@connorlwilkes
Copy link

With respect to private GKE and webhooks this will be really useful across the board for Kubeflow.

@stale
Copy link

stale bot commented Dec 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@andreyvelich
Copy link
Member Author

/lifecycle frozen

@andreyvelich
Copy link
Member Author

Since we designed new cert-generator: #1450, we should update the Katib README: https://github.com/kubeflow/katib#components-in-katib and add information about the current webhooks update process (Maybe https://github.com/kubeflow/katib/blob/master/docs/developer-guide.md is a good place to add).
/priority p0

This was referenced Mar 18, 2021
Closed
Merged
@ryan-ally ryan-ally mentioned this issue Nov 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/docs area/katib good first issue Good for newcomers help wanted Extra attention is needed kind/feature lifecycle/frozen priority/p0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Katib webhook documentation andreyvelich/katib
4 participants
@connorlwilkes @k8s-ci-robot @andreyvelich @google-oss-robot