-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for File Metrics Collector #1756
Comments
@andreyvelich: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/lifecycle frozen |
I want to have a try! It may help me better understand the logics of metrics collecting. |
Sure, feel free to assign this yourself with a "/assign" comment. |
/assign |
@tenzen-y thank you! |
@tenzen-y I notice that you left a comment in the unit test file
Does it mean that the additional test cases are supposed to be TEXT format? If so, can you provide an example of TEXT format log file for me? Thanks! |
Yes, that's right. We have UTs only for JSON form. So, we need to add UTs for TEXT form logs. |
@andreyvelich I would love to contribute to this issue just wanted to ask that I have to add unit tests for parseLogsInTextFormat and parseLogsInJsonFormat functions and modify test cases in this file, am I right?? |
@kshitijdshah99 This is already taken by @Electronic-Waste. I'd be happy to be taken another issue by you. |
@tenzen-y Current error comparison in |
SGTM |
/reopen We need another followup PR. |
@tenzen-y: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind feature
We should add unit test for our File Metrics Collector to verify log parsing.
That will help to avoid issues similar to: #1754
/help
/good-first-issue
Love this feature? Give it a 👍 We prioritize the features with the most 👍
The text was updated successfully, but these errors were encountered: