Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Show Valid Katib UI Link #2099

Open
andreyvelich opened this issue Jan 24, 2023 · 10 comments
Open

[SDK] Show Valid Katib UI Link #2099

andreyvelich opened this issue Jan 24, 2023 · 10 comments
Assignees
Labels
area/sdk good first issue Good for newcomers help wanted Extra attention is needed lifecycle/frozen

Comments

@andreyvelich
Copy link
Member

Check this thread: #2098 (comment).

Currently, we show Katib UI link when Katib SDK is used from Kubernetes pod and SDK loads in-cluster config.
We use it to identify whether Katib SDK is ran from Kubeflow Notebook and we generate link to the appropriate Kubeflow Central Dashboard page.
User might also run Katib SDK in-cluster, but not from Kubeflow Notebooks UI.

We should find another approach to identify if Katib SDK is used from the Kubeflow Notebooks.
cc @kimwnasptd

/area sdk


Love this feature? Give it a 👍 We prioritize the features with the most 👍

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@andreyvelich
Copy link
Member Author

/lifecycle frozen

@andreyvelich
Copy link
Member Author

/good-first-issue

Copy link

@andreyvelich:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 29, 2024
@kshitijdshah99
Copy link

@tenzen-y @andreyvelich I would love to work on this issue!

@kshitijdshah99
Copy link

/assign

@tenzen-y
Copy link
Member

tenzen-y commented Mar 4, 2024

Feel free to take this one.

@Mu-Magdy
Copy link

Hi @tenzen-y

Is this issue solved or I can work on it?

@tenzen-y
Copy link
Member

Hi @tenzen-y

Is this issue solved or I can work on it?

@kshitijdshah99 already took this.

@Mu-Magdy
Copy link

Hi @tenzen-y
Is this issue solved or I can work on it?

@kshitijdshah99 already took this.

Can I work on it in parallel with @kshitijdshah99?
or compare the final pr

If not, Can you suggest an issue that is not assigned yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sdk good first issue Good for newcomers help wanted Extra attention is needed lifecycle/frozen
Projects
None yet
Development

No branches or pull requests

4 participants