Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Support customized trial template name in UI #834

Closed
gaocegege opened this issue Sep 29, 2019 · 6 comments
Closed

[enhancement] Support customized trial template name in UI #834

gaocegege opened this issue Sep 29, 2019 · 6 comments

Comments

@gaocegege
Copy link
Member

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

@gaocegege
Copy link
Member Author

/area front-end
/priority p3

@yeya24
Copy link
Contributor

yeya24 commented Oct 2, 2019

Can you explain this feature request a little bit? Why do we need this feature, I think we already have a select list

@gaocegege
Copy link
Member Author

@yeya24

https://github.com/kubeflow/katib/blob/master/pkg/ui/v1alpha3/frontend/src/components/HP/Create/HPParameters.jsx#L130

In front-end, the configmap name is hard-coded. The list only contains the templates defined in the hard-coded configmap.

@andreyvelich
Copy link
Member

andreyvelich commented Mar 24, 2020

@gaocegege I believe, we can close this, since we support Trial Templates in all namespaces and all configMaps names. (PR: #1083)

@andreyvelich
Copy link
Member

/close

@k8s-ci-robot
Copy link

@andreyvelich: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants