Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to deploy using deploy.sh #886

Closed
mannuscript opened this issue Oct 16, 2019 · 5 comments
Closed

Unable to deploy using deploy.sh #886

mannuscript opened this issue Oct 16, 2019 · 5 comments
Labels

Comments

@mannuscript
Copy link

/kind bug

What steps did you take and what happened:
I am trying to deploy katib on minikube using deploy.sh provided in the examples. But there seems to be a problem:

> ./deploy.sh
+ set -e
+ minikube start --disk-size 50g --memory 4096 --cpus 4
😄  minikube v1.4.0 on Darwin 10.13.6
💡  Tip: Use 'minikube start -p <name>' to create a new cluster, or 'minikube delete' to delete this one.
🏃  Using the running hyperkit "minikube" VM ...
⌛  Waiting for the host to be provisioned ...
🐳  Preparing Kubernetes v1.16.0 on Docker 18.09.9 ...
🔄  Relaunching Kubernetes using kubeadm ...
⌛  Waiting for: apiserver proxy etcd scheduler controller dns
🏄  Done! kubectl is now configured to use "minikube"
+ bash ../../../scripts/v1alpha3/deploy.sh
++ dirname ../../../scripts/v1alpha3/deploy.sh
+ SCRIPT_ROOT=../../../scripts/v1alpha3/../..
+ cd ../../../scripts/v1alpha3/../..
+ kubectl apply -f manifests/v1alpha3
namespace/kubeflow unchanged
+ kubectl apply -f manifests/v1alpha3/katib-controller
customresourcedefinition.apiextensions.k8s.io/experiments.kubeflow.org unchanged
customresourcedefinition.apiextensions.k8s.io/suggestions.kubeflow.org unchanged
customresourcedefinition.apiextensions.k8s.io/trials.kubeflow.org unchanged
configmap/katib-config unchanged
deployment.apps/katib-controller unchanged
clusterrole.rbac.authorization.k8s.io/katib-controller unchanged
serviceaccount/katib-controller unchanged
clusterrolebinding.rbac.authorization.k8s.io/katib-controller unchanged
secret/katib-controller unchanged
service/katib-controller unchanged
configmap/trial-template unchanged
+ kubectl apply -f manifests/v1alpha3/manager
service/katib-manager unchanged
error: unable to recognize "manifests/v1alpha3/manager/deployment.yaml": no matches for kind "Deployments" in version "extensions/v1beta1"

Anything else you would like to add:
But it works when I change the api version to stable one:

diff --git a/manifests/v1alpha3/db/deployment.yaml b/manifests/v1alpha3/db/deployment.yaml
index e819af46..4781545b 100644
--- a/manifests/v1alpha3/db/deployment.yaml
+++ b/manifests/v1alpha3/db/deployment.yaml
@@ -1,4 +1,4 @@
-apiVersion: extensions/v1beta1
+apiVersion: apps/v1
 kind: Deployment
 metadata:
   name: katib-db
@@ -8,6 +8,10 @@ metadata:
     component: db
 spec:
   replicas: 1
+  selector:
+    matchLabels:
+        app: katib
+        component: db
   template:
     metadata:
       name: katib-db
diff --git a/manifests/v1alpha3/manager/deployment.yaml b/manifests/v1alpha3/manager/deployment.yaml
index bba4ed0e..76e80d7f 100644
--- a/manifests/v1alpha3/manager/deployment.yaml
+++ b/manifests/v1alpha3/manager/deployment.yaml
@@ -1,4 +1,4 @@
-apiVersion: extensions/v1beta1
+apiVersion: apps/v1
 kind: Deployment
 metadata:
   name: katib-manager
@@ -8,6 +8,10 @@ metadata:
     component: manager
 spec:
   replicas: 1
+  selector:
+    matchLabels:
+        app: katib
+        component: manager
   template:
     metadata:
       name: katib-manager
diff --git a/manifests/v1alpha3/ui/deployment.yaml b/manifests/v1alpha3/ui/deployment.yaml
index 1b38e333..a78ae552 100644
--- a/manifests/v1alpha3/ui/deployment.yaml
+++ b/manifests/v1alpha3/ui/deployment.yaml
@@ -1,4 +1,4 @@
-apiVersion: extensions/v1beta1
+apiVersion: apps/v1
 kind: Deployment
 metadata:
   name: katib-ui
@@ -8,6 +8,10 @@ metadata:
     component: ui
 spec:
   replicas: 1
+  selector:
+    matchLabels:
+        app: katib
+        component: ui
   template:
     metadata:
       name: katib-ui

Environment:

  • Minikube version: v1.4.0
  • Kubernetes version: (use kubectl version): v1.13.3, v1.16.0 client and server respectively.
@johnugeorge
Copy link
Member

Support for extensions/v1beta1 as the API group is removed in 1.16
https://kubernetes.io/blog/2019/09/18/kubernetes-1-16-release-announcement/

@RochanMehrotra
Copy link

@mannuscript workaround works for me!

@johnugeorge
Copy link
Member

Changes are merged as part of #937

@johnugeorge
Copy link
Member

Closing the PR
/close

@k8s-ci-robot
Copy link

@johnugeorge: Closing this issue.

In response to this:

Closing the PR
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants