Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FileMetricsCollector]skip line without metrics keywords #1018

Merged
merged 1 commit into from
Jan 17, 2020
Merged

[FileMetricsCollector]skip line without metrics keywords #1018

merged 1 commit into from
Jan 17, 2020

Conversation

sperlingxx
Copy link
Member

@sperlingxx sperlingxx commented Jan 16, 2020

What this PR does / why we need it:
This PR purpose a tiny refinement on FileMetricsCollector. When parsing logs, it is better to skip line which doesn't contain any metrics keywords, so as to avoid unnecessary string matches.


This change is Reviewable

@k8s-ci-robot
Copy link

Hi @sperlingxx. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johnugeorge
Copy link
Member

/ok-to-test

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for your contribution! 🎉 👍

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cfbd851 into kubeflow:master Jan 17, 2020
@sperlingxx sperlingxx deleted the file-mc-refine branch January 20, 2020 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants