Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic jobProvider and suggestionComposer registration #1069

Merged
merged 10 commits into from
Feb 28, 2020
Merged

dynamic jobProvider and suggestionComposer registration #1069

merged 10 commits into from
Feb 28, 2020

Conversation

sperlingxx
Copy link
Member

@sperlingxx sperlingxx commented Feb 25, 2020

Add registry for jobProvider and suggestionComposer, so it is easy to add new Provider or Composer via init function without modifying existing files.
In addition, Provider includes an additonal method MutateJob, which allows some custom mutation on jobSpec before its creation.


This change is Reviewable

@k8s-ci-robot
Copy link

Hi @sperlingxx. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Generally LGTM with some nits

pkg/controller.v1alpha3/trial/trial_controller_test.go Outdated Show resolved Hide resolved
pkg/job/v1alpha3/job/job.go Outdated Show resolved Hide resolved
pkg/job/v1alpha3/kubeflow/kubeflow.go Outdated Show resolved Hide resolved
pkg/job/v1alpha3/provider.go Outdated Show resolved Hide resolved
@sperlingxx sperlingxx requested a review from gaocegege February 26, 2020 10:08
@andreyvelich
Copy link
Member

/ok-to-test

@sperlingxx
Copy link
Member Author

@andreyvelich I think this PR is ready.

@andreyvelich
Copy link
Member

/retest

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sperlingxx Thanks!
/lgtm
/cc @gaocegege

@gaocegege
Copy link
Member

/approve

Thanks for the PR!

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnugeorge
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 8267929 into kubeflow:master Feb 28, 2020
@sperlingxx sperlingxx deleted the enhance_flexbility_of_controller branch February 28, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants