Add more unit tests in Katib

cmd/db-manager/v1alpha3/main_test.go

@@ -6,6 +6,7 @@ import (
 
 	"github.com/golang/mock/gomock"
 
+	health_pb "github.com/kubeflow/katib/pkg/apis/manager/health"
 	api_pb "github.com/kubeflow/katib/pkg/apis/manager/v1alpha3"
 	mockdb "github.com/kubeflow/katib/pkg/mock/v1alpha3/db"
 )
@@ -131,3 +132,40 @@ func TestDeleteObservationLog(t *testing.T) {
 		t.Fatalf("DeleteExperiment Error %v", err)
 	}
 }
+
+func TestCheck(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	defer ctrl.Finish()
+	s := &server{}
+	mockDB := mockdb.NewMockKatibDBInterface(ctrl)
+	dbIf = mockDB
+	testCases := []struct {
+		Request        *health_pb.HealthCheckRequest
+		ExpectedStatus health_pb.HealthCheckResponse_ServingStatus
+		Name           string
+	}{
+		{
+			Request: &health_pb.HealthCheckRequest{
+				Service: "grpc.health.v1.Health",
+			},
+			ExpectedStatus: health_pb.HealthCheckResponse_SERVING,
+			Name:           "Valid Request",
+		},
+		{
+			Request: &health_pb.HealthCheckRequest{
+				Service: "grpc.health.v1.1.Health",
+			},
+			ExpectedStatus: health_pb.HealthCheckResponse_UNKNOWN,
+			Name:           "Invalid service name",
+		},
+	}
+
+	mockDB.EXPECT().SelectOne().Return(nil)
+
+	for _, tc := range testCases {
+		response, _ := s.Check(context.Background(), tc.Request)
+		if response.Status != tc.ExpectedStatus {
+			t.Fatalf("Case %v failed. ExpectedStatus %v, got %v", tc.Name, tc.ExpectedStatus, response.Status)
+		}
+	}
+}

pkg/db/v1alpha3/mysql/mysql_test.go

@@ -112,9 +112,9 @@ func TestGetObservationLog(t *testing.T) {
 	)
 	obsLog, err := dbInterface.GetObservationLog(
 		"test1_trial1",
-		"",
+		"loss",
 		"2016-12-31T21:01:05.123456Z",
-		"",
+		"2016-12-31T22:10:20.123456Z",
 	)
 	if err != nil {
 		t.Errorf("GetObservationLog failed %v", err)
@@ -123,3 +123,25 @@ func TestGetObservationLog(t *testing.T) {
 	}
 
 }
+
+func TestDeleteObservationLog(t *testing.T) {
+	trialName := "test1_trial1"
+
+	mock.ExpectExec(
+		"DELETE FROM observation_logs",
+	).WithArgs(trialName).WillReturnResult(sqlmock.NewResult(1, 1))
+
+	err := dbInterface.DeleteObservationLog(trialName)
+	if err != nil {
+		t.Errorf("DeleteObservationLog failed: %v", err)
+	}
+}
+
+func TestGetDbName(t *testing.T) {
+	dbName := "root:@tcp(katib-mysql:3306)/katib?timeout=5s"
+
+	if getDbName() != dbName {
+		t.Errorf("getDbName returns wrong value %v", getDbName())
+	}
+
+}

pkg/webhook/v1alpha3/experiment/validator/validator.go

@@ -162,7 +162,7 @@ func (g *DefaultValidator) validateMetricsCollector(inst *experimentsv1alpha3.Ex
 			continue
 		}
 		if _, err := g.GetMetricsCollectorImage(mcKind); err != nil {
-			return fmt.Errorf("Don't support metrics collector kind %q: %v.", string(mcKind), err)
+			return fmt.Errorf("GetMetricsCollectorImage failed: %v.", err)
 		}
 		break
 	}