Fix custom Katib DB Manager env variables #1102
Conversation
|
@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: kunalyogenshah. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This change is |
| } | ||
|
|
||
| return dbManagerIP + ":" + dbManagerPort |
There was a problem hiding this comment.
Is this logic be used anytime?
There was a problem hiding this comment.
This will be used when namespace is explicitly set to empty,
|
/lgtm |
|
/cc @gaocegege |
| @@ -126,4 +135,11 @@ var ( | |||
| DefaultKatibNamespace = env.GetEnvOrDefault(DefaultKatibNamespaceEnvName, "kubeflow") | |||
| // DefaultComposer is the default composer of katib suggestion. | |||
| DefaultComposer = env.GetEnvOrDefault(DefaultKatibComposerEnvName, "General") | |||
|
|
|||
| // DefaultKatibDBManagerServiceNamespace is the default namespace of Katib DB Manager | |||
| DefaultKatibDBManagerServiceNamespace = env.GetEnvOrDefault(DefaultKatibDBManagerServiceNamespaceEnvName, DefaultKatibNamespace) | |||
There was a problem hiding this comment.
LGTM but I think we should illustrate the relationship between DefaultKatibNamespace and DefaultKatibDBManagerServiceNamespace in the doc in the future.
There was a problem hiding this comment.
Sure, I will create doc about all env variables in Katib components today
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Fix custom Katib DB Manager info * Change names for Katib db manager env
Fixes this comment: #981 (comment).
If users want to use their own DB Manager, they must specify these env variables in Katib controller and Katib UI manifests:
Also, if user specifies
KATIB_DB_MANAGER_SERVICE_NAMESPACE='', we will useKATIB_DB_MANAGER_SERVICE_IP:KATIB_DB_MANAGER_SERVICE_PORTfor DB manager address .This might be useful, if user needs to send metrics to DataBase which is not deployed in Kubernetes.
I tried to deploy
katib-db-managerin the different namespace thankatib-controller. After set correct env, metrics got collected.In the next PR I will create doc about all env variables that can be specifying in the manifest.
What do you think @johnugeorge @gaocegege @hougangliu ?
/cc @kunalyogenshah