Refactor suggestion-internal-modules #1106
Conversation
|
Hi @c-bata. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -50,12 +50,12 @@ def convertParameter(p): | |||
|
|
|||
|
|
|||
| class HyperParameter(object): | |||
| def __init__(self, name, type, min, max, list, step): | |||
| def __init__(self, name, type_, min_, max_, list_, step): | |||
There was a problem hiding this comment.
In Python, These are common practices to avoid shadows of built-in methods and variables.
|
/assign @johnugeorge |
|
This change is |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
Thank you for your swift review 😄 OK. I'll submit some refactoring pull requests before working on #1100. |
|
/retest |
|
CI seems to be slow now |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):None
Special notes for your reviewer:
None.
Release note: