Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Katib e2e tests #1118

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Conversation

andreyvelich
Copy link
Member

I made few changes in e2e test. I hope it will fix running problems.

  1. Deleted part of creating ${GO_DIR}. According to this PR: fix: Remove copy #802, we deleted from some e2e test this part. I think it should fix problem with cp: cannot create symbolic link error.
  2. Deleted NAMESPACE and REGISTRY env variable, since it is not needed.
  3. Deleted part of describing pods and deploy in default namespace and other describe in some e2e test.
  4. I left only describe appropriate Experiment in each e2e test. I think it is more informative.

/assign @johnugeorge @gaocegege

@andreyvelich
Copy link
Member Author

/retest

@johnugeorge
Copy link
Member

/lgtm
/approve

@kubeflow-bot
Copy link

This change is Reviewable

@andreyvelich
Copy link
Member Author

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 688636e into kubeflow:master Apr 3, 2020
sperlingxx pushed a commit to sperlingxx/katib that referenced this pull request Jul 9, 2020
@andreyvelich andreyvelich deleted the fix-e2e-tests branch October 6, 2021 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants