Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename chocolate algorithm names for consistency #1164

Merged
merged 1 commit into from
Apr 26, 2020

Conversation

c-bata
Copy link
Member

@c-bata c-bata commented Apr 23, 2020

What this PR does / why we need it:
Rename chocolate algorithm names for consistency.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

To close #1163.

Related discussions are kubeflow/website#1907 (comment) and #1131 (comment).

Special notes for your reviewer:

None

Release note:

Rename algorithm names of chocolate suggestion service.
Algorithm names that start with `chocolate-` are deprecated.

@kubeflow-bot
Copy link

This change is Reviewable

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c-bata c-bata force-pushed the consistent-algorithm-name branch from 45c71e2 to ef82a9d Compare April 26, 2020 05:01
@k8s-ci-robot k8s-ci-robot removed the lgtm label Apr 26, 2020
@c-bata
Copy link
Member Author

c-bata commented Apr 26, 2020

I resolved conflicts with #1166

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for your contribution! 🎉 👍

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 93f177f into kubeflow:master Apr 26, 2020
@c-bata c-bata deleted the consistent-algorithm-name branch April 26, 2020 08:22
sperlingxx pushed a commit to sperlingxx/katib that referenced this pull request Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Chocolate algorithm names
5 participants