Fix additional metrics in TF Event metrics collector #1191
Conversation
|
@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: sadeel. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This change is |
| @@ -39,7 +39,7 @@ def parse_options(): | |||
|
|
|||
| WaitOtherMainProcesses(completed_marked_dir=opt.dir_path) | |||
|
|
|||
| mc = MetricsCollector(opt.metric_names.split(',')) | |||
| mc = MetricsCollector(opt.metric_names.split(';')) | |||
There was a problem hiding this comment.
/lgtm
/approve
Thanks for your contribution! 🎉 👍
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: #1188.
I changed split metrics from "," to ";".
See comment: #1188 (comment).
Do we need to modify TF Job example (https://github.com/kubeflow/katib/blob/master/examples/v1alpha3/tfjob-example.yaml) with additional metric, for example:
cross_entropy_1?/assign @johnugeorge @gaocegege
/cc @sadeel