Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Katib v1beta1 version #1197

Merged
merged 7 commits into from
May 28, 2020
Merged

Conversation

andreyvelich
Copy link
Member

I added v1beta1 version to continue Katib development and adding new API changes.
See discussion: #1186.

  1. All API and Controller logics are the same as in v1alpha3 .

  2. I didn't make doc changes in this PR, only for https://github.com/andreyvelich/katib/blob/v1beta1-version/docs/developer-guide.md, because I changed Makefile. For other doc we can make changes in the separate PR, since it will affect Kubeflow website.

  3. For Makefile I changed corresponding scripts (deploy, undeploy, ..) to new v1beta1 version. Old scripts I renamed to <script-name>v1alpha3 accordingly.

  4. For Swagger I created API for v1alpha3 and v1beta1 versions. @sperlingxx Do we need to make v0.1 Swagger version for every Katib version (https://github.com/andreyvelich/katib/blob/v1beta1-version/hack/swagger/main.go#L65) ? If not, I can rename it to appropriate Katib version.

/assign @johnugeorge @gaocegege

@kubeflow-bot
Copy link

This change is Reviewable

@andreyvelich
Copy link
Member Author

/retest

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@andreyvelich
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 27, 2020
@andreyvelich
Copy link
Member Author

@johnugeorge @gaocegege I disabled e2e test for custom metrics collector in v1beta1.
In this PR: #908, we didn't add the source code for the image: kubeflowkatib/custom-metrics-collector, so I can't modify it.

Currently, in this metrics collector we report metrics using api.v1.alpha3.Manager, but we need to use api.v1.beta1.Manager in the new version.

I added comment to e2e test and yaml file for the custom metrics collector.

@andreyvelich
Copy link
Member Author

/retest

1 similar comment
@andreyvelich
Copy link
Member Author

/retest

@gaocegege
Copy link
Member

/lgtm
/approve

I think we can merge it and fix problems in other PRs if there is any.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6e7a1aa into kubeflow:master May 28, 2020
sperlingxx pushed a commit to sperlingxx/katib that referenced this pull request Jul 9, 2020
* Add v1beta1 version

* Swagger for v1alpha3 and v1beta1 versions
Fix format in bash scripts

* Change make build to make buildv1alpha3

* Add folder path to python test

* Fix folder in python test

* Add goptuna and darts suggestions to check-katib-ready

* Disable custom metrics collector e2e in v1beta1
@andreyvelich andreyvelich deleted the v1beta1-version branch October 6, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants