Custom CRD: Wait for all processes before running metrics collector #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
andreyvelich
force-pushed
the
issue-1214-finish-proc-for-mc
branch
from
968b157 to
c485517
Compare
|
/lgtm |
andreyvelich
force-pushed
the
issue-1214-finish-proc-for-mc
branch
from
c485517 to
62aae3d
Compare
|
@johnugeorge @gaocegege Can you approve this PR again, please? |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1214.
I refactored metrics collector to wait for all other process to finish before running parser.
I had to switch to
gopsutillibrary to identify which process is the main and try to be consistent with Pythonpsutillib.I search for
echo completed > /var/log/katibin PID'scmdlineto find the main PID./assign @gaocegege @johnugeorge @sperlingxx