Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MPI operator horovod example #1342

Merged
merged 4 commits into from
Oct 17, 2020
Merged

Add MPI operator horovod example #1342

merged 4 commits into from
Oct 17, 2020

Conversation

andreyvelich
Copy link
Member

This example of using MPI operator with Horovod mnist example. Blocked by: #1333.

Fixes: #1181.

/assign @gaocegege @johnugeorge

/cc @terrytangyuan @YuxiJin-tobeyjin @carmark

@k8s-ci-robot
Copy link

@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: YuxiJin-tobeyjin.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

This example of using MPI operator with Horovod mnist example. Blocked by: #1333.

Fixes: #1181.

/assign @gaocegege @johnugeorge

/cc @terrytangyuan @YuxiJin-tobeyjin @carmark

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeflow-bot
Copy link

This change is Reviewable

@andreyvelich andreyvelich mentioned this pull request Oct 3, 2020
Closed
@andreyvelich andreyvelich changed the title [WIP] Add MPI operator horovod example Add MPI operator horovod example Oct 14, 2020
@terrytangyuan
Copy link
Member

Is this ready for review yet?

@andreyvelich
Copy link
Member Author

andreyvelich commented Oct 14, 2020 •
edited
Loading

@terrytangyuan It's ready, it should work with merged controller code base.

terrytangyuan
terrytangyuan approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@carmark
Copy link
Member

carmark commented Oct 15, 2020

/lgtm

gaocegege
gaocegege reviewed Oct 16, 2020
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

andreyvelich
andreyvelich commented Oct 16, 2020
View reviewed changes
Copy link
Member Author

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@aws-kf-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, carmark, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, carmark, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 8ebba43 into kubeflow:master Oct 17, 2020
@andreyvelich andreyvelich mentioned this pull request Oct 17, 2020
Closed
12 tasks
@andreyvelich andreyvelich deleted the add-mpi-example branch October 3, 2021 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@carmark carmark carmark approved these changes

Assignees

@carmark carmark

@johnugeorge johnugeorge

@terrytangyuan terrytangyuan

@gaocegege gaocegege

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Katib doesn't support mpijob
8 participants
@andreyvelich @k8s-ci-robot @kubeflow-bot @terrytangyuan @carmark @aws-kf-ci-bot @gaocegege @johnugeorge