Update Katib operator and image #1465
Conversation
google-oss-robot
requested review from
DomFleischmann,
hougangliu and
sperlingxx
There was a problem hiding this comment.
Thank you for your contribution @knkski!
I left few comments.
|
|
||
| validating, mutating = yaml.safe_load_all(Path("src/webhooks.yaml").read_text()) | ||
|
|
||
| self.model.pod.set_spec( |
There was a problem hiding this comment.
I think it would be great to create a script to automatically generate this spec from the appropriate YAML manifests.
There was a problem hiding this comment.
I've opened this issue to talk about supporting it in the operator framework directly:
| @@ -0,0 +1,77 @@ | |||
| apiVersion: admissionregistration.k8s.io/v1 | |||
There was a problem hiding this comment.
Do you need to have your own YAML for the webhooks or you can use it from the source: /manifest/v1beta1/... ?
There was a problem hiding this comment.
See canonical/charmcraft#260 for why we can't symlink it to the existing file. If you'd like, I could take a look at adding a Makefile or similar that would copy the file over before calling charmcraft build.
There was a problem hiding this comment.
Got it, thank you for the information.
Maybe we can include this file copy in the script that I mentioned here: #1465 (comment).
Thus, this script will take care about changes between operator manifests and the Katib original manifests.
WDYT @knkski ?
We can add this script in the future PRs.
knkski
force-pushed
the
katib-operator-updates
branch
2 times, most recently
from
e1d8648 to
c9de12d
Compare
Updates Docker image to include changes from kubeflow#1450, and updates operator to latest version of operator framework.
knkski
force-pushed
the
katib-operator-updates
branch
from
c9de12d to
4bc5a0c
Compare
|
@knkski Should we merge this PR ? |
|
@andreyvelich: Yeah, this should be good to merge |
|
Thank you for doing this @knkski! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, DomFleischmann, knkski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, DomFleischmann, knkski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Updates Docker image to include changes from kubeflow#1450, and updates operator to latest version of operator framework.
Updates Docker image to include changes from kubeflow#1450, and updates operator to latest version of operator framework.
Updates Docker image to include changes from kubeflow#1450, and updates operator to latest version of operator framework.
What this PR does / why we need it:
Updates Docker image to include changes from #1450, and updates operator to latest version of operator framework.
Which issue(s) this PR fixes:
Fixes #1453