Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty resources for CPU and Memory in Katib config #1564

Conversation

andreyvelich
Copy link
Member

@andreyvelich andreyvelich commented Jun 26, 2021

Fixes: #1559.
This will allow to specify empty resources for CPU and Memory in Katib config.

/cc @gaocegege @johnugeorge @sravi999

@google-oss-robot
Copy link

@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: sravi999.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Fixes: #1559.
This will allow specify empty resources for CPU and Memory.

/cc @gaocegege @johnugeorge @sravi999

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnugeorge
Copy link
Member

/lgtm
Do we have any tests just to check this?

@google-oss-robot google-oss-robot merged commit 61d7008 into kubeflow:master Jun 29, 2021
@andreyvelich andreyvelich deleted the issue-1559-allow-empty-resources-config branch September 15, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controller should allow an empty CPU resource limit
3 participants