Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mysql version in docker image #1594

Merged
merged 1 commit into from
Aug 2, 2021
Merged

fix mysql version in docker image #1594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/v1beta1/components/mysql/mysql.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ spec:
spec:
containers:
- name: katib-mysql
image: mysql:8
image: mysql:8.0.26
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add imagePullPolicy: Always here to avoid problems with caching data if users are running another mysql instance for other components ?
I remember that we had couple of problems with that.

Copy link
Contributor Author

@munagekar munagekar Jul 30, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imagePullPolicy: Always is not required as long mysql:8.0.26 tag image is not updated in dockerhub, and cache can be used if available.

However, I don't have any strong opinion, I can add it if you feel so.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any use-case when mysql team can update previous image tag on the dockerhub ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at release history & dockerhub Mysql Team hasn't done it. I think it should be fine without imagePullPolicy:"Always"

A possible usecase would be when Dockerimages such as ubuntu are rebuilt and pushed again to dockerhub when there are security fixes. Mysql doesn't seem to do so either.

Even if there were to be a security fix with mysql docker image. The mysql version would remain the same and this issue would not occur.

[InnoDB] Cannot boot server version 80017 on data directory built by version 80018. Downgrade is not supported

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the explanation @munagekar!

args:
- --datadir
- /var/lib/mysql/datadir
Expand Down