SDK: change list apis to return objects as default #1630
Conversation
|
Hi @anencore94. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
google-oss-robot
requested review from
andreyvelich,
johnugeorge and
sperlingxx
There was a problem hiding this comment.
Thank you for taking this @anencore94!
I left few comments.
|
/ok-to-test |
|
/retest |
|
/hold Please let's merge this PR after Katib 0.12 release. After this change: #1572, we still need to do some work to modify our SDK and KFP examples to support the latest SDK changes. Since this PR will add some additional functionality, we can include it in the next release (e.g. Katib 0.13). What do you think @gaocegege @johnugeorge @anencore94 ? |
I agree. I'm not sure when Katib 0.12 will be released, but this feature change the API of sdk, this feature should change the minor version |
|
Since release branch is created, we can merge it to master |
|
/retest |
|
Is there any reason why kubeflow-katib-presubmit fail sometimes ? |
Sometime tests can be flaky, we have to restart it couple of times. |
|
/assign @anencore94 |
- change list_trials, list_experiments to return list of objects as a default - also, give 'in_short' parameter for who wants only name and status as before
anencore94
force-pushed
the
enhance/list_api
branch
from
f030899
to
ecf9e64
Compare
|
/retest |
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
There was a problem hiding this comment.
Thank you @anencore94!
/lgtm
@gaocegege @johnugeorge Please take a look.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anencore94, johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1447
Checklist:
Questions To Members