Add GitHub Actions for Python unit tests #1677
Conversation
google-oss-robot
requested review from
anencore94,
gaocegege and
johnugeorge
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
andreyvelich
force-pushed
the
issue-1601-python-github-actions
branch
from
66e6827 to
f58b470
Compare
andreyvelich
changed the title
|
This PR is ready. |
| pip install -r cmd/suggestion/hyperband/v1beta1/requirements.txt | ||
| pip install -r cmd/suggestion/nas/darts/v1beta1/requirements.txt | ||
|
|
||
| pip install -r cmd/earlystopping/medianstop/v1beta1/requirements.txt |
There was a problem hiding this comment.
LGTM, maybe in the future we can introduce the python site-packages cache to accelerate the building process.
| - name: Run Python test | ||
| run: | | ||
| export PYTHONPATH=$(pwd):$(pwd)/pkg/apis/manager/v1beta1/python:$(pwd)/pkg/apis/manager/health/python | ||
| echo $PYTHONPATH |
There was a problem hiding this comment.
could we remove this line after debugging?
There was a problem hiding this comment.
Nice catch. I will address your comments in the following PR.
| pip install grpcio-testing==1.40.0 | ||
| pip install pytest==5.1.2 |
There was a problem hiding this comment.
How about make a requirements.txt including this packages at the source root directory ?
Related: #1601.
Blocked by: #1674.
I moved Python unit tests to GitHub Actions.
/cc @gaocegege @anencore94 @johnugeorge