Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readme in examples directory #1687

Merged

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Sep 29, 2021

What this PR does / why we need it:

  • FIx the hyperlink for PytorchJob because pytorch-operator was integrated tf-operator.
  • Remove the description of how to access Katib UI for users using Kubernetes <= 1.9 because Katib supports Kubernetes >= 1.17.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@tenzen-y tenzen-y force-pushed the fix-readme-for-example-directory branch from 48e1ceb to 93ce2e0 Compare September 29, 2021 20:21
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this @tenzen-y!
I have plans to refactor this README (after this PR: #1688) since Minikube example is outdated.
/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 2940919 into kubeflow:master Sep 29, 2021
@tenzen-y tenzen-y deleted the fix-readme-for-example-directory branch September 30, 2021 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants