Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhance] change default metrics collect format #1707

Merged
merged 2 commits into from
Oct 11, 2021
Merged

[enhance] change default metrics collect format #1707

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c6371d
[enhance] change default metrics collect format
anencore94 Oct 8, 2021
962116a
Update pkg/metricscollector/v1beta1/common/const.go
anencore94 Oct 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/metricscollector/v1beta1/common/const.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,10 @@ const (
// Metrics must be printed this way
// loss=0.3
// accuracy=0.98
DefaultFilter = `([\w|-]+)\s*=\s*((-?\d+)(\.\d+)?)`
// Score=-7.53e-05
anencore94 marked this conversation as resolved.
Show resolved Hide resolved
// Score=1E0
// Score=1.23E10
DefaultFilter = `([\w|-]+)\s*=\s*([+-]?\d(\.\d+)?([Ee][+-]?\d+)?)`

// TODO (andreyvelich): Do we need to maintain 2 names? Should we leave only 1?
MetricCollectorContainerName = "metrics-collector"
Expand Down