-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Workflow to Publish Katib Images #1746
Add Workflow to Publish Katib Images #1746
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think my suggestion method is somewhat bothersome stuff, but we could save limitation if we split each image's trigger point to only dependent PATH changed. For example:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature is very useful!
I left some comments.
@anencore94 I think currently we give our users experience when they can use images with specific commit for all Katib components. I think that approach simplify Katib usage to understand which changes our users try to deploy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updating! @andreyvelich
/lgtm
/hold |
Yeah, This could make users feel much easier to try on. Thanks :) |
@james-jwu @zijianjoy @Bobgy Please take a look at this PR. |
We updated the token with @zijianjoy, let's try to merge this PR. |
After this PR, images will be automatically published to our Docker Hub after every commit to the
master
branch.So we don't need to manually run
make push-latest
after each PR.We still need to update repository settings with Docker Hub token.
GitHub Actions has limitation of 20 concurrent jobs: https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration#usage-limits in Free plan, that is why I split the workflows to:
Core
,Algorithms
, andTrials
.Please take a look at this workflow.
/assign @gaocegege @johnugeorge @tenzen-y