Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifests: Increate the probes seconds #1845

Merged
merged 1 commit into from
Apr 11, 2022
Merged

manifests: Increate the probes seconds #1845

merged 1 commit into from
Apr 11, 2022

Conversation

haoxins
Copy link
Contributor

@haoxins haoxins commented Apr 11, 2022

What this PR does / why we need it:

The current probe delay seconds are not suitable for the most environments.
We should increase these values.

@aws-kf-ci-bot
Copy link
Contributor

Hi @haoxins. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anencore94
Copy link
Member

I agree with you :) /lgtm

@anencore94
Copy link
Member

/ok-to-test

@johnugeorge
Copy link
Member

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoxins, johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit c62bacd into kubeflow:master Apr 11, 2022
@haoxins haoxins deleted the inc-the-probe-secs branch April 11, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants