Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operators/katib-*: pins pip and setuptools versions to avoid installation issues #1867

Merged
merged 1 commit into from
May 18, 2022

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented May 18, 2022

Due to pypa/setuptools-scm#713, we are experiencing errors when building charms both locally and in the CI. This change will prevent the error from happening until the issue is fixed.

This PR fixes the CI errors reported in #1866

@google-oss-prow google-oss-prow bot requested review from sperlingxx and tenzen-y May 18, 2022 12:27
@DnPlas DnPlas force-pushed the dnplas/fix-charmed-katib-ci branch from a9912d0 to 90f3975 Compare May 18, 2022 12:30
…tion issues

Due to pypa/setuptools-scm#713, we are experiencing errors when building
charms both locally and in the CI. This change will prevent the error
from happening until the issue is fixed.
@DnPlas DnPlas force-pushed the dnplas/fix-charmed-katib-ci branch from 90f3975 to e2b5309 Compare May 18, 2022 12:32
@coveralls
Copy link

coveralls commented May 18, 2022

Coverage Status

Coverage increased (+0.02%) to 73.93% when pulling e2b5309 on DnPlas:dnplas/fix-charmed-katib-ci into 3993404 on kubeflow:master.

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @DnPlas !
/lgtm

@johnugeorge
Copy link
Member

Thanks!
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DnPlas, johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit ea23e71 into kubeflow:master May 18, 2022
@tenzen-y tenzen-y mentioned this pull request May 20, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants