Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semicolon when using command command in Makefile #1885

Merged
merged 2 commits into from
Jun 4, 2022

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Jun 4, 2022

What this PR does / why we need it:
To avoid the make: command: Command not found error, I have added -v option when using the command command in #1884, although we received the same error message again.

Run go mod download
make: command: Command not found
make: command: Command not found
make: command: Command not found
go generate ./pkg/... ./cmd/...
Generate deepcopy, clientset, listers, informers for the APIs

https://github.com/kubeflow/katib/runs/6736557128?check_suite_focus=true#step:5:10

According to this StackOverflow comment, we need to add a semicolon when using the command command on the Ubuntu machine.

you must have a version of GNU make pre 4.3, that doesn't realize command is a shell built-in. You can force it by adding a semicolon like: $(shell command -v python3;)

https://stackoverflow.com/questions/63286462/gnu-make-check-whether-a-python-module-needs-to-be-installed

After applying this patch, I confirmed that we don't receive the error message in this job.

Run go mod download
go generate ./pkg/... ./cmd/...
Generate deepcopy, clientset, listers, informers for the APIs

/assign @johnugeorge

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

… the `make: command: Command not found` error.
@coveralls
Copy link

coveralls commented Jun 4, 2022

Coverage Status

Coverage remained the same at 73.948% when pulling 5f2b501 on tenzen-y:add-semicolon-in-makefile into b9314c6 on kubeflow:master.

@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Jun 4, 2022
@tenzen-y tenzen-y force-pushed the add-semicolon-in-makefile branch from e2c8755 to 5f2b501 Compare June 4, 2022 09:27
@johnugeorge
Copy link
Member

Thanks
/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jun 4, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 5c7dce6 into kubeflow:master Jun 4, 2022
@tenzen-y tenzen-y deleted the add-semicolon-in-makefile branch June 4, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants