Add the CI to build multi-platform container images #1956
Conversation
google-oss-prow
bot
requested review from
andreyvelich,
johnugeorge and
sperlingxx
tenzen-y
force-pushed
the
add-ci-to-build-multi-arch-image
branch
from
caa7b8b to
e0f7eeb
Compare
tenzen-y
changed the title
tenzen-y
force-pushed
the
add-ci-to-build-multi-arch-image
branch
2 times, most recently
from
43dc46c to
3bd4764
Compare
| dockerfile: examples/v1beta1/trial-images/pytorch-mnist/Dockerfile.cpu | ||
| - trial-name: pytorch-mnist-gpu | ||
| platforms: linux/amd64 |
There was a problem hiding this comment.
Since we face the below error, we can not build multiplatform container images with GPU support.
Once we use AWS self-hosted runner, we will be able to build it.
System.IO.IOException: No space left on device : '/home/runner/runners/2.296.2/_diag/Worker_20220918-065331-utc.log'
at System.IO.RandomAccess.WriteAtOffset(SafeFileHandle handle, ReadOnlySpan`1 buffer, Int64 fileOffset)
at System.IO.Strategies.BufferedFileStreamStrategy.FlushWrite()
at System.IO.StreamWriter.Flush(Boolean flushStream, Boolean flushEncoder)
at System.Diagnostics.TextWriterTraceListener.Flush()
at GitHub.Runner.Common.HostTraceListener.WriteHeader(String source, TraceEventType eventType, Int32 id)
at GitHub.Runner.Common.HostTraceListener.TraceEvent(TraceEventCache eventCache, String source, TraceEventType eventType, Int32 id, String message)
at System.Diagnostics.TraceSource.TraceEvent(TraceEventType eventType, Int32 id, String message)
at GitHub.Runner.Worker.Worker.RunAsync(String pipeIn, String pipeOut)
at GitHub.Runner.Worker.Program.MainAsync(IHostContext context, String[] args)
System.IO.IOException: No space left on device : '/home/runner/runners/2.296.2/_diag/Worker_20220918-065331-utc.log'
at System.IO.RandomAccess.WriteAtOffset(SafeFileHandle handle, ReadOnlySpan`1 buffer, Int64 fileOffset)
at System.IO.Strategies.BufferedFileStreamStrategy.FlushWrite()
at System.IO.StreamWriter.Flush(Boolean flushStream, Boolean flushEncoder)
at System.Diagnostics.TextWriterTraceListener.Flush()
at GitHub.Runner.Common.HostTraceListener.WriteHeader(String source, TraceEventType eventType, Int32 id)
at GitHub.Runner.Common.HostTraceListener.TraceEvent(TraceEventCache eventCache, String source, TraceEventType eventType, Int32 id, String message)
at System.Diagnostics.TraceSource.TraceEvent(TraceEventType eventType, Int32 id, String message)
at GitHub.Runner.Common.Tracing.Error(Exception exception)
at GitHub.Runner.Worker.Program.MainAsync(IHostContext context, String[] args)
Unhandled exception. System.IO.IOException: No space left on device : '/home/runner/runners/2.296.2/_diag/Worker_20220918-065331-utc.log'
at System.IO.RandomAccess.WriteAtOffset(SafeFileHandle handle, ReadOnlySpan`1 buffer, Int64 fileOffset)
at System.IO.Strategies.BufferedFileStreamStrategy.FlushWrite()
at System.IO.StreamWriter.Flush(Boolean flushStream, Boolean flushEncoder)
at System.Diagnostics.TextWriterTraceListener.Flush()
at System.Diagnostics.TraceSource.Flush()
at GitHub.Runner.Common.TraceManager.Dispose(Boolean disposing)
at GitHub.Runner.Common.TraceManager.Dispose()
at GitHub.Runner.Common.HostContext.Dispose(Boolean disposing)
at GitHub.Runner.Common.HostContext.Dispose()
at GitHub.Runner.Worker.Program.Main(String[] args)
| type: boolean | ||
| default: false | ||
| description: whether to deploy training-operator or not | ||
| default: "false" |
There was a problem hiding this comment.
Needs to specify string data.
|
|
||
| inputs: | ||
| experiments: | ||
| required: true | ||
| type: string |
There was a problem hiding this comment.
|
|
||
| inputs: | ||
| experiments: | ||
| required: true | ||
| type: string | ||
| description: comma delimited experiment name |
There was a problem hiding this comment.
Needs to specify description field.
tenzen-y
changed the title
tenzen-y
force-pushed
the
add-ci-to-build-multi-arch-image
branch
from
3bd4764 to
987a447
Compare
|
How long does it take in CI now ? |
@johnugeorge Maybe, over an hour but I'm not sure about the accurate duration. Would you like to see how long it will take by restarting all jobs? |
Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com>
tenzen-y
force-pushed
the
add-ci-to-build-multi-arch-image
branch
from
987a447 to
f150aad
Compare
|
I have pushed to kick the CI. |
|
@johnugeorge I have checked what it spends about 2 hours for CI since this PR. So, It might be better to introduce the order to run jobs using For example, Lint test -> Unit test -> Build test -> Integration Test. What do you think? |
|
@tenzen-y How does it help? |
@johnugeorge Introducing |
|
Sure. Do you want to do it in a separate PR? |
Yes, I would like to create a separate PR to resolve it since I created this PR to resolve #1900. |
|
Ready to merge this? |
Yes. Let's merge this! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: tenzen-y yuki.iwai.tz@gmail.com
What this PR does / why we need it:
I added the CI to build multi-platform container images using composite action and reusable workflows.
Also, I cleaned up config files for actions according to the below documents.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1900
Checklist: