-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the license to pbt #1958
Add the license to pbt #1958
Conversation
Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com>
@kubeflow/wg-automl-leads PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hey @tenzen-y & @gaocegege! I originally excluded the KF copyright on this file since it is heavily based on / copied from the Ray implementation here. I defer to your expertise, but wanted to surface this point in the event it necessitates changing anything! |
@a9p Thanks for your response! Although, we might be able to add readme, same as other trial images such as the tf-mnit-with-summaries since it would be good to clarify that the simple-pbt is heavily based on from Ray. WDYT? |
Signed-off-by: tenzen-y yuki.iwai.tz@gmail.com
What this PR does / why we need it:
I added the license to PBT.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: