[SDK] Remove Final Keyword from constants #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@andreyvelich Can you do a rebase? |
tenzen-y
reviewed
Oct 24, 2022
There was a problem hiding this comment.
@andreyvelich Thanks for pointing this out!
/lgtm
I think that we could upgrade the minimal support python version to v3.8 still releasing katib v0.15.
andreyvelich
force-pushed
the
sdk-remove-final-keyword
branch
from
ad37961 to
c78f789
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think, we should remove Final keyword from our constants in Python SDK.
Final is available only in >= Python 3.8 version: https://peps.python.org/pep-0591/
Currently, we say that Katib SDK is supported in Python 3 and 3.7.
Also, it's better to be compatible with other Kubeflow components SDKs, e.g. with Kubeflow Pipelines.
We can think about Python upgrade in the future releases/versions across various Kubeflow components.