-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for k8s v1.25 in CI #1997
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnugeorge Thanks for updating the kubernetes version!
Can you also upgrade the setup-envtest version, K8s version for envtest, prerequires version in Readme, and kind version for example?
Line 23 in 68ecb1c
go install sigs.k8s.io/controller-runtime/tools/setup-envtest@c7a98aa706379c4e5c79ea675c7f333192677971 # v0.12.3 |
Line 9 in 68ecb1c
ENVTEST_K8S_VERSION ?= 1.24 |
katib/examples/v1beta1/kind-cluster/deploy.sh
Lines 39 to 41 in 68ecb1c
# Step 1. Create Kind cluster with Kubernetes v1.24.4 | |
kind create cluster --image kindest/node:v1.24.4 | |
echo -e "\nKind cluster has been created\n" |
@@ -29,7 +29,7 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
kubernetes-version: ["v1.22.14", "v1.23.11", "1.24.5"] | |||
kubernetes-version: ["v1.23.12", "v1.24.6", "v1.25.2"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the latest patch versions (1.23.13, 1.24.7, 1.25.3)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change setup-envtest to 2c3a6fa2996c026b284c7fe2b055274cd9a556bc # v0.13.0
ref: #1993 |
@johnugeorge |
Thanks! |
K8s 1.25 is added to CI and 1.22 is dropped.
Kubernetes dependencies are also updated to v0.25.3
Fixes: #1957