Add scripts to verify generated codes and Go Modules

[tenzen-y]

Signed-off-by: tenzen-y yuki.iwai.tz@gmail.com

What this PR does / why we need it:
I added scripts to generate Go mock files to Makefile.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #59

Checklist:

• Docs included if any changes are user facing

[coveralls]

Coverage increased (+1.0%) to 73.419% when pulling 4ff0e5c on tenzen-y:add-mockgen-to-makefile into 54b020b on kubeflow:master.

[andreyvelich]

Thanks for taking this @tenzen-y!

I think to cover this issue: #59 we also want to add unit test to verify that contributor runs make generate before creating PR.

Should we update our unit tests to verify that source code doesn't have any changes after running make generate ?

[tenzen-y]

Thanks for taking this @tenzen-y!

I think to cover this issue: #59 we also want to add unit test to verify that contributor runs make generate before creating PR.

Should we update our unit tests to verify that source code doesn't have any changes after running make generate ?

Thanks for the review!

Does that mean we add scripts to Makefile or create the shellscript file like the following?

katib/.github/workflows/test-go.yaml

Lines 38 to 43 in 0848e03

	- name: Run Generate And Go Format Test
	run: |
	go mod download &&
	make check &&
	git add pkg/apis hack/gen-python-sdk &&
	git diff --cached --exit-code || (echo 'Please run "make check" to generate codes and to format Go codes' && exit 1)

[andreyvelich]

@tenzen-y It's a good idea to re-use this unit test to check if contributor forgot to run make check or go mod tidy.
Should we add more files in addition to (git add pkg/apis hack/gen-python-sdk) to check if make generate needs to be ran ?

[tenzen-y]

@tenzen-y It's a good idea to re-use this unit test to check if contributor forgot to run make check or go mod tidy. Should we add more files in addition to (git add pkg/apis hack/gen-python-sdk) to check if make generate needs to be ran ?

It makes sense.

[tenzen-y]

@andreyvelich Are there any other directories that need to be checked?

[andreyvelich]

@tenzen-y What do you think about verifying the whole code base on the changes
(e.g. git diff --exit-code -- . )?
For example, tomorrow we are going to introduce script check to automatically sync operator manifests with our manifests and we ask users to run this script before submitting PR.

[tenzen-y]

It makes sense.
I will change so that developer can check all files.

[andreyvelich]

Should we keep code generation check in 1 hack script ?
Then, we can reduce our number of scripts.

[tenzen-y]

Sure, thanks!

[andreyvelich]

@tenzen-y What do you think about verifying the whole code base on the changes
(e.g. git diff --exit-code -- . )?
For example, tomorrow we are going to introduce script check to automatically sync operator manifests with our manifests and we ask users to run this script before submitting PR.

[tenzen-y]

@andreyvelich I addressed your suggestions. PTAL

[andreyvelich]

Thanks for the updates @tenzen-y!
/lgtm
/assign @johnugeorge

[johnugeorge]

/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [johnugeorge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment