fix: only validate Kubernetes Job #2025
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| return fmt.Errorf("unable to convert spec.TrialTemplate: %v to %v: %v", runSpec.Object, gvk.Kind, err) | ||
| } | ||
| // Validate only Kuernetes Job | ||
| if gvk.GroupVersion() != batchv1.SchemeGroupVersion { |
There was a problem hiding this comment.
Thank you for this update @zhixian82, just small nit from me.
| if err != nil { | ||
| return fmt.Errorf("unable to convert spec.TrialTemplate: %v to %v: %v", runSpec.Object, gvk.Kind, err) | ||
| } | ||
| // Validate only Kuernetes Job |
There was a problem hiding this comment.
| // Validate only Kuernetes Job | |
| // Validate only Kubernetes Job |
|
@zhixian82 Can you do a rebase as well? |
done |
There was a problem hiding this comment.
@zhixian82 Thanks for the first awesome contribution!
/lgtm
|
/assign @andreyvelich @johnugeorge |
|
/approve Thanks @zhixian82 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge, zhixian82 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #2021