[bugfix] Fix value passing bug in New Experiment form #2027
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at the integration of our previous YAML editor (
ace-editor
), we found out that we do not take the appropriate actions in order to pass thecustomYaml
input as part of the form it is in.Steps to reproduce the issue:
Metrics Collector
>Kind: Custom
>Editor
Create
orEdit and Submit YAML
An error will come up since we haven't set up properly a new experiment but if in our browser we use
Inspect
>Network (tab)
>create_experiment
>postData
>spec
. We can seemetricsCollectorSpec
>source
hasn't any updated data in the section below:(https://github.com/kubeflow/katib/blob/master/examples/v1beta1/metrics-collector/custom-metrics-collector.yaml#L18-L35)
This PR resolves the above bug by adding missing logic in New Experiment form in order to pass the value of the editor content in Metrics Collector tab, when Kind is set to Custom.