Dedicated yaml tab for Trials #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work @elenzio9 |
|
Related Issue for Suggestion: #1439 |
|
@orfeas-k since you've also helped with developing the monaco editor component kubeflow/kubeflow#6733 could you also take a stab at the review? /cc @kimwnasptd |
orfeas-k
reviewed
Nov 28, 2022
There was a problem hiding this comment.
Just a small nit @elenzio9 you could rename openTrialModal() as well. Everything else lgtm @kimwnasptd
* Create a dedicated yaml tab for Trials. Signed-off-by: Elena Zioga <elena@arrikto.com>
* Rename trial-modal component to trial-details. * Rename trial-modal-overview component to trial-overview. Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9
force-pushed
the
feature-elena-kwa-yaml-tab
branch
from
36cc535
to
f966ba1
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elenzio9, kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new yaml tab in the Trial details page that shows the full YAML as it comes from the backend.
Here's a screenshot:
Related issue: #2011