Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK] Use Katib SDK for E2E Tests #2075

Merged
merged 15 commits into from
Jan 16, 2023
Merged

[SDK] Use Katib SDK for E2E Tests #2075

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
709c8ad
[SDK] Use Katib SDK for E2E tests
andreyvelich Jan 4, 2023
1abffb9
Fix pvc deletion
andreyvelich Jan 4, 2023
be11377
Add list_suggestions API
andreyvelich Jan 4, 2023
5c0f944
Remove wait from edit Experiment function
andreyvelich Jan 5, 2023
bfd0ceb
Add shell to GitHub action
andreyvelich Jan 5, 2023
80e4efa
Add protobuf package to Katib SDK
andreyvelich Jan 5, 2023
f4187e3
Add Experiment Timeout to 40 min
andreyvelich Jan 5, 2023
edbd3a0
Modify SDK Examples
andreyvelich Jan 6, 2023
3f57005
Fix example text
andreyvelich Jan 6, 2023
296c781
Change to custom_api
andreyvelich Jan 6, 2023
8f283ed
Enable verbose logging for Katib E2E
andreyvelich Jan 9, 2023
98a12ca
Use expected condition arg
andreyvelich Jan 9, 2023
2a79a6f
Add timeout and delete options
andreyvelich Jan 10, 2023
99821e0
Modify logging to debug
andreyvelich Jan 10, 2023
a84c920
Use read API to check resource status
andreyvelich Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/template-e2e-test/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ inputs:
training-operator:
required: false
description: whether to deploy training-operator or not
default: "false"
default: false
trial-images:
required: true
description: comma delimited trial image name
katib-ui:
required: true
description: whether to deploy katib-ui or not
default: "false"
description: whether to deploy katib-ui or not
default: false
database-type:
required: false
description: mysql or postgres
Expand All @@ -25,11 +25,11 @@ inputs:
runs:
using: composite
steps:
- name: Set Up Minikube Cluster
- name: Setup Minikube Cluster
shell: bash
run: ./test/e2e/v1beta1/scripts/gh-actions/setup-minikube.sh ${{ inputs.katib-ui }} ${{ inputs.trial-images }} ${{ inputs.experiments }}

- name: Set Up Katib
- name: Setup Katib
shell: bash
run: ./test/e2e/v1beta1/scripts/gh-actions/setup-katib.sh ${{ inputs.katib-ui }} ${{ inputs.training-operator }} ${{ inputs.database-type }}

Expand Down
18 changes: 11 additions & 7 deletions .github/workflows/template-setup-e2e-test/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,23 @@ inputs:
runs:
using: composite
steps:
- name: Set Up Minikube Cluster
- name: Setup Minikube Cluster
uses: manusa/actions-setup-minikube@v2.7.2
with:
minikube version: 'v1.28.0'
minikube version: v1.28.0
kubernetes version: ${{ inputs.kubernetes-version }}
start args: --wait-timeout=60s
driver: 'none'
driver: none
github token: ${{ env.GITHUB_TOKEN }}

- name: Set Up Docker Buildx
- name: Setup Docker Buildx
uses: docker/setup-buildx-action@v2

- name: Set Up Go env
uses: actions/setup-go@v3
- name: Setup Python
uses: actions/setup-python@v4
with:
go-version-file: go.mod
python-version: 3.9

- name: Install Katib SDK
shell: bash
run: pip install -e sdk/python/v1beta1
Loading