-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a --prefer-binary flag to 'pip install' command #2096
Add a --prefer-binary flag to 'pip install' command #2096
Conversation
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@@ -13,7 +13,7 @@ ENV TARGET_DIR /opt/katib | |||
ENV SUGGESTION_DIR cmd/suggestion/hyperopt/v1beta1 | |||
ENV PYTHONPATH ${TARGET_DIR}:${TARGET_DIR}/pkg/apis/manager/v1beta1/python:${TARGET_DIR}/pkg/apis/manager/health/python | |||
|
|||
RUN if [ "${TARGETARCH}" = "ppc64le" ] || [ "${TARGETARCH}" = "aarch64" ]; then \ | |||
RUN if [ "${TARGETARCH}" = "ppc64le" ]; then \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BuildKit propagates TARGETARCH
with amd64
or arm64
. However, we have been able to build container images for the platform linux/arm64 with an incorrect value, aarch64
.
This means we don't need these packages for the platform linux/arm64
.
I found a better solution. |
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
/hold cancel |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the prompt fix @tenzen-y !
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Yuki Iwai yuki.iwai.tz@gmail.com
What this PR does / why we need it:
I pinned the h5py version with 3.7.0 to resolve image-building errors. These errors are caused by the latest h5py not releasing the wheel for aarch64.I added a --prefer-binary flag to
pip install
command to resolve the following build errors.Doc: https://pip.pypa.io/en/stable/cli/pip_install/#cmdoption-prefer-binary
Also, these errors are caused by the latest h5py not releasing the binary for aarch64.
Ref: h5py/h5py#2215
Blocking #2077 #2091 #2092 #2094
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: