Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK: Import all Kubernetes Models #2148

Merged

Conversation

andreyvelich
Copy link
Member

Fixes: #2110
Currently, we need to import all Kubernetes models to Katib SDK, so SDK can do proper deserialization.

We need to track better solution in: kubeflow/training-operator#1723

/assign @johnugeorge @tenzen-y @votti

@google-oss-prow
Copy link

@andreyvelich: GitHub didn't allow me to assign the following users: votti.

Note that only kubeflow members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Fixes: #2110
Currently, we need to import all Kubernetes models to Katib SDK, so SDK can do proper deserialization.

We need to track better solution in: kubeflow/training-operator#1723

/assign @johnugeorge @tenzen-y @votti

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andreyvelich!

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Apr 20, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andreyvelich,tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit fcea7a3 into kubeflow:master Apr 20, 2023
@andreyvelich andreyvelich deleted the issue-2110-sdk-fix-import branch April 20, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KatibClient().list_experiments/list_trials fails with RuntimeError
3 participants