-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Katib ROADMAP 2022/2023 #2153
Conversation
@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: d-gol, shaowei-su, fischor, keisuke-umezawa, zhixian82. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for compiling our roadmap!
Also, I'm thinking of creating a separate CRD for the Nas might be better. Since currently Experiment CRD seems to be a bit complex.
- Support advance HyperParameter tuning algorithms: | ||
|
||
- Population Based Training (PBT) - [#1382](https://github.com/kubeflow/katib/issues/1382) | ||
- Tree of Parzen Estimators (TPE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, we already supported the TPE a long time ago, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right @tenzen-y.
Since this ROADMAP for 2022/2023, I tried to outline features that we already implemented in 2022 there, so users will have overview of what we do in 2022-2023.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see.
That's great! Thanks for clarifying!
@tenzen-y Yes, we were discussing about this before, how to separate various AutoML features from the Kubernetes CRD perspective:
Then, it will be easier to maintain APIs for every aspect of AutoML. |
Oh, I see. Thank you for letting me know :) It would be worth creating an issue for discussion. |
I feel, we need to make API changes in this release if we are planning to do so. |
If we can collect contributors to do that, we can do that in this release. However, changing the API name is so significant work... |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Should we merge this? |
Sure, I removed Katib CRDs naming (Experiment, Suggestion, Trial) from the ROADMAP, since we need to discuss what naming we are going to have in our V1 APIs version. If other items look good, we can merge it. |
12db58c
to
4b0b539
Compare
LGTM! |
Thanks Andrey! |
/hold cancel |
# network-plugin: cni | ||
# cni: flannel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to set up CNI due to kubernetes/minikube#16143.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, let me add it back.
Not sure why we are getting the following error in our CI:
chmod: cannot access '/etc/cni/net.d': No such file or directory
Error: The process '/usr/bin/sudo' failed with exit code 1
Any ideas ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why the error occurs. How about upgrading the Ubuntu version?
runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me try that, 23.04
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright 22.04 work, let me submit separate PR to update the ubuntu version for our E2Es.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
288100c
to
4b0b539
Compare
4b0b539
to
6357e37
Compare
/hold cancel |
/lgtm |
I created initial draft for Katib ROADMAP 2022/2023.
I tried to consolidated features that we implemented in 2022, since we didn't update the ROADMAP in 2022 (if I missed some significant features that we've done, please let me know).
Please let me know if you have better ideas how to name headers.
Let's discuss the items during next month and finalise the ROADMAP.
/cc @johnugeorge @gaocegege @tenzen-y @anencore94 @kimwnasptd @elenzio9 @orfeas-k @apo-ger @d-gol @shaowei-su @zhixian82 @fischor @keisuke-umezawa @jbottum @DnPlas @juliusvonkohout
cc @kubeflow/wg-training-leads