-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace grpc_health_probe with the built-in gRPC container probe feature #2189
Replace grpc_health_probe with the built-in gRPC container probe feature #2189
Conversation
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating this @tenzen-y!
/assign @gaocegege @johnugeorge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @johnugeorge @gaocegege
/hold for review
Then we could only support clusters above 1.24, if I understand it correctly. But LGTM. |
@gaocegege Thanks for the review. Yes, that's right. We're ok with supporting only clusters above v1.24 since the K8s v1.25 is required for the next katib version as a minimum required version: #2155 |
SGTM |
/hold cancel |
What this PR does / why we need it:
The built-in gRPC container probe has been enabled as a default since K8s v1.24.
https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-a-grpc-liveness-probe
So we should replace grpc_health_probe with a built-in one.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: